Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update documentation to include SparsePauliOp spin chain input #2606

Merged

Conversation

mjrodriguez
Copy link
Contributor

@mjrodriguez mjrodriguez commented Jan 29, 2025

  • Q-CTRL optimizer will now be supporting spin chains of the form SparsePauliOp
  • Updating optimizer documentation

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rowenwu
Copy link
Contributor

rowenwu commented Jan 29, 2025

note: do not merged until update is released

@rowenwu
Copy link
Contributor

rowenwu commented Jan 29, 2025

@mjrodriguez can you assign me as a reviewer ?

@mjrodriguez
Copy link
Contributor Author

@rowenwu I don't believe I can add you as a reviewer. If I there is a way, then it's not immediately obvious to me. Additionally, as long as the PR remains as a draft it wont be able to be merged. Once we're ready, then I'll mark as ready.

@mjrodriguez mjrodriguez marked this pull request as ready for review February 5, 2025 17:28
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

@@ -33,7 +33,7 @@
"![Visualization of the Optimization Solver workflow](/images/guides/qctrl-optimization/solver_workflow.svg)\n",
Copy link
Contributor

@rowenwu rowenwu Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spin chain representation of a specific problem. The spin chain should be represented as a SparsePauliOp object.

Can this be updated for brevity?


Reply via ReviewNB

@rowenwu
Copy link
Contributor

rowenwu commented Feb 10, 2025

@mjrodriguez looks good, just one small edit.

@abbycross
Copy link
Collaborator

Does this need an approving review from @rowenwu? If not I can merge.

Copy link
Contributor

@rowenwu rowenwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Martin!

@abbycross abbycross added this pull request to the merge queue Feb 14, 2025
Merged via the queue into Qiskit:main with commit 3f10840 Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants